Discussion:
Build failure in pyicu
(too old to reply)
Mark Meyer
2017-12-15 09:26:26 UTC
Permalink
Raw Message
Hi,
I've got a build failure in PyICU (python2-pyicu) during the test phase:

======================================================================
FAIL: testSurrogatePairs (test.test_Script.TestScript)
----------------------------------------------------------------------
Traceback (most recent call last):
File
"/tmp/guix-build-python2-pyicu-1.9.8.drv-0/PyICU-1.9.8/test/test_Script.py",
line 48, in testSurrogatePairs
self.assertEqual(['Latn', 'Deva', 'Hani', 'Zzzz', 'Zzzz'], names)
AssertionError: Lists differ: ['Latn', 'Deva', 'Hani', 'Zzzz... !=
['Latn', 'Deva', 'Hani', 'Zyyy...

First differing element 3:
'Zzzz'
'Zyyy'

- ['Latn', 'Deva', 'Hani', 'Zzzz', 'Zzzz']
? ^^^ ^^^

+ ['Latn', 'Deva', 'Hani', 'Zyyy', 'Zyyy']
? ^^^ ^^^


----------------------------------------------------------------------
Ran 39 tests in 0.458s

FAILED (failures=1)
phase `check' failed after 0.9 seconds
builder for
`/gnu/store/s62yr0llv2f2yf7m36p4dq7r45ciy46b-python2-pyicu-1.9.8.drv'
failed with exit code 1
@ build-failed
/gnu/store/s62yr0llv2f2yf7m36p4dq7r45ciy46b-python2-pyicu-1.9.8.drv - 1
builder for
`/gnu/store/s62yr0llv2f2yf7m36p4dq7r45ciy46b-python2-pyicu-1.9.8.drv'
failed with exit code 1
cannot build derivation
`/gnu/store/1s0wa8lq3xgmjaf3zv9d3limwyh5538w-virtaal-0.4.1.drv': 1
dependencies couldn't be built
guix build: error: build failed: build of
`/gnu/store/1s0wa8lq3xgmjaf3zv9d3limwyh5538w-virtaal-0.4.1.drv' failed

Cheers, Mark
--
Mark Meyer
***@ofosos.org
Tobias Geerinckx-Rice
2017-12-15 10:41:41 UTC
Permalink
Raw Message
Post by Mark Meyer
Hi,
======================================================================
FAIL: testSurrogatePairs (test.test_Script.TestScript)
----------------------------------------------------------------------
Hrm, this looks like another encoding- or locale-related failure[0] —
although I guess with packages like these, all failures look that way.

I suggest simply deleting the test, like we previously did with
test_DateTimeParserGenerator.py. I'm testing that now, but slowly...

Kind regards,

T G-R

[0]: https://github.com/ovalhub/pyicu/issues/61
Tobias Geerinckx-Rice
2017-12-15 10:47:59 UTC
Permalink
Raw Message
* gnu/packages/python.scm (python2-pyicu)[arguments]: Add
‘delete-failing-test’ phase.
---

Mark,

...of course it finishes right after I send that previous e-mail.

This patch makes the build pass for me. Could you confirm whether it
works for you?

Kind regards,

T G-R

gnu/packages/python.scm | 15 ++++++++++++++-
1 file changed, 14 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index e36056d45..372b5afe3 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -1130,7 +1130,20 @@ Python 3.3+.")
(license license:x11)))

(define-public python2-pyicu
- (package-with-python2 python-pyicu))
+ (let ((base (package-with-python2
+ (strip-python2-variant python-pyicu))))
+ (package
+ (inherit base)
+ (arguments
+ `(,@(package-arguments base)
+ #:phases
+ (modify-phases %standard-phases
+ (add-before 'check 'delete-failing-test
+ (lambda _
+ ;; XXX: This fails due to Unicode issues unique to Python 2,
+ ;; it seems: <https://github.com/ovalhub/pyicu/issues/61>.
+ (delete-file "test/test_Script.py")
+ #t))))))))

(define-public python2-dogtail
;; Python 2 only, as it leads to "TabError: inconsistent use of tabs and
--
2.15.0
Mark Meyer
2017-12-15 10:58:22 UTC
Permalink
Raw Message
Tobias,
thanks for the patch, this works for me :)

Cheers, Mark
Post by Tobias Geerinckx-Rice
* gnu/packages/python.scm (python2-pyicu)[arguments]: Add
‘delete-failing-test’ phase.
---
Mark,
...of course it finishes right after I send that previous e-mail.
This patch makes the build pass for me. Could you confirm whether it
works for you?
Kind regards,
T G-R
gnu/packages/python.scm | 15 ++++++++++++++-
1 file changed, 14 insertions(+), 1 deletion(-)
diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm
index e36056d45..372b5afe3 100644
--- a/gnu/packages/python.scm
+++ b/gnu/packages/python.scm
@@ -1130,7 +1130,20 @@ Python 3.3+.")
(license license:x11)))
(define-public python2-pyicu
- (package-with-python2 python-pyicu))
+ (let ((base (package-with-python2
+ (strip-python2-variant python-pyicu))))
+ (package
+ (inherit base)
+ (arguments
+ #:phases
+ (modify-phases %standard-phases
+ (add-before 'check 'delete-failing-test
+ (lambda _
+ ;; XXX: This fails due to Unicode issues unique to Python 2,
<https://github.com/ovalhub/pyicu/issues/61>.
+ (delete-file "test/test_Script.py")
+ #t))))))))
(define-public python2-dogtail
;; Python 2 only, as it leads to "TabError: inconsistent use of tabs and
--
2.15.0
--
Mark Meyer
***@ofosos.org
Tobias Geerinckx-Rice
2017-12-15 11:17:34 UTC
Permalink
Raw Message
Mark,
Post by Mark Meyer
thanks for the patch, this works for me :)
Wonderful! Pushed as d65854bdda4ad5464fcd8fe6289eedc13ea82ba1.

(Just FYI: if you post to bug-***@gnu.org next time, you'll get the
visceral satisfaction of closing yet another bug. ;-)

Kind regards,

T G-R
Mark Meyer
2017-12-15 12:30:39 UTC
Permalink
Raw Message
However, for some reason python2-vobject fails to pick up this change
and fails to build :(
Post by Tobias Geerinckx-Rice
Mark,
Post by Mark Meyer
thanks for the patch, this works for me :)
Wonderful! Pushed as d65854bdda4ad5464fcd8fe6289eedc13ea82ba1.
visceral satisfaction of closing yet another bug. ;-)
Kind regards,
T G-R
--
Mark Meyer
***@ofosos.org
Tobias Geerinckx-Rice
2017-12-15 15:45:40 UTC
Permalink
Raw Message
Mark,
Post by Mark Meyer
However, for some reason python2-vobject fails to pick up this change
and fails to build :(
Nuts. You're right.

Long story and 2 drafts short: I had some mystical (and wrong) ideas
about package-with-python2 that have now been set straight and pushed to
master.

It can do magic all right, but only if you slowly put the rabbit in the
hat while it's watching and loudly say ‘Loook! Rabbit!’.

Like a dog wizard,

T G-R

Loading...