Discussion:
core-updates, let’s go!
Add Reply
Ludovic Courtès
2017-12-31 10:27:37 UTC
Reply
Permalink
Raw Message
Hello Guix!

‘core-updates’ is doing OK!

https://hydra.gnu.org/jobset/gnu/core-updates

The remaining issues are GCC 4.8 and 4.9 failing to build, which are
nothing serious and left as an exercise to the reader.

What about starting a new evaluation of all the packages now so we can
merge it early 2018?

Efraim, can you confirm that everything’s alright on aarch64?

We’re lacking a couple of glibc commits from the ‘release/2.26/master’
branch (see below), but Florian Weimer marked them as non-critical
provided we have the previous fixes. Should we include them anyway and
rebuild the whole thing? (I’m inclined to answer “no”.)

Thanks,
Ludo’.


commit 633e2f7f3d88df6427aa3a7a984d3a6b796d9611 (HEAD -> release/2.26/master, origin/release/2.26/master)
Author: Florian Weimer <***@redhat.com>
Date: Thu Dec 14 15:05:57 2017 +0100

elf: Count components of the expanded path in _dl_init_path [BZ #22607]

(cherry picked from commit 3ff3dfa5af313a6ea33f3393916f30eece4f0171)

commit 43b3cb59b2288953efc26e70fe7c6eb437513b1f
Author: Florian Weimer <***@redhat.com>
Date: Thu Dec 14 15:18:38 2017 +0100

elf: Compute correct array size in _dl_init_paths [BZ #22606]

(cherry picked from commit 8a0b17e48b83e933960dfeb8fa08b259f03f310e)
Efraim Flashner
2017-12-31 10:32:19 UTC
Reply
Permalink
Raw Message
Post by Ludovic Courtès
Hello Guix!
‘core-updates’ is doing OK!
https://hydra.gnu.org/jobset/gnu/core-updates
The remaining issues are GCC 4.8 and 4.9 failing to build, which are
nothing serious and left as an exercise to the reader.
What about starting a new evaluation of all the packages now so we can
merge it early 2018?
I've merged master into core-updates and I'm running 'make' against it
as we speak to make sure I didn't make any obvious errors, and then I'm
about to push it.
Post by Ludovic Courtès
Efraim, can you confirm that everything’s alright on aarch64?
I've been keeping mesa in good shape on aarch64, I'm pretty sure gtk+,
Post by Ludovic Courtès
We’re lacking a couple of glibc commits from the ‘release/2.26/master’
branch (see below), but Florian Weimer marked them as non-critical
provided we have the previous fixes. Should we include them anyway and
rebuild the whole thing? (I’m inclined to answer “no”.)
Thanks,
Ludo’.
commit 633e2f7f3d88df6427aa3a7a984d3a6b796d9611 (HEAD -> release/2.26/master, origin/release/2.26/master)
Date: Thu Dec 14 15:05:57 2017 +0100
elf: Count components of the expanded path in _dl_init_path [BZ #22607]
(cherry picked from commit 3ff3dfa5af313a6ea33f3393916f30eece4f0171)
commit 43b3cb59b2288953efc26e70fe7c6eb437513b1f
Date: Thu Dec 14 15:18:38 2017 +0100
elf: Compute correct array size in _dl_init_paths [BZ #22606]
(cherry picked from commit 8a0b17e48b83e933960dfeb8fa08b259f03f310e)
--
Efraim Flashner <***@flashner.co.il> א׀ךים ׀לשנך
GPG key = A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted
Danny Milosavljevic
2017-12-31 11:14:16 UTC
Reply
Permalink
Raw Message
I'd like to get the patch

[bug#29856] [PATCH core-updates] guix: python-build-system: Modify ".py" files in-place.

into this core-updates cycle. What do you all think?

If we don't do it then a lot of Python programs (the ones who use "console_scripts" in setup.py as they should) will not work (because we emit a shell script wrapper and Python tries to import it - that's going to end badly). On the other hand, I don't know the effect on other programs (read: I didn't build the world with it - but I did build quite a few Python programs). You can try it with the guix package ledger-agent and try to invoke "ledger-agent".

The patch only affects files whose names end in ".py" since Python's importer will only find those in any case. So its possible ill effect is limited.

Hartmut, what do you think?
Danny Milosavljevic
2017-12-31 12:20:37 UTC
Reply
Permalink
Raw Message
On Sun, 31 Dec 2017 12:14:16 +0100
Post by Danny Milosavljevic
I'd like to get the patch
[bug#29856] [PATCH core-updates] guix: python-build-system: Modify ".py" files in-place.
into this core-updates cycle. What do you all think?
If we don't do it then a lot of Python programs (the ones who use "console_scripts" in setup.py as they should) will not work (because we emit a shell script wrapper and Python tries to import it - that's going to end badly). On the other hand, I don't know the effect on other programs (read: I didn't build the world with it - but I did build quite a few Python programs). You can try it with the guix package ledger-agent and try to invoke "ledger-agent".
The patch only affects files whose names end in ".py" since Python's importer will only find those in any case. So its possible ill effect is limited.
^^^ Correction: whose names end in ".py" and that end up in "bin" or "sbin". Otherwise it would be common.
Post by Danny Milosavljevic
Hartmut, what do you think?
--
W: https://www.friendly-machines.at/
Marius Bakke
2017-12-31 15:07:21 UTC
Reply
Permalink
Raw Message
Post by Danny Milosavljevic
I'd like to get the patch
[bug#29856] [PATCH core-updates] guix: python-build-system: Modify ".py" files in-place.
into this core-updates cycle. What do you all think?
We already have a substantial amount of Python changes on core-updates,
so we could save ourselves some trouble by adding this when there's less
"congestion" in case of any problems.
Ricardo Wurmus
2017-12-31 17:27:12 UTC
Reply
Permalink
Raw Message
Post by Marius Bakke
Post by Danny Milosavljevic
I'd like to get the patch
[bug#29856] [PATCH core-updates] guix: python-build-system: Modify ".py" files in-place.
into this core-updates cycle. What do you all think?
We already have a substantial amount of Python changes on core-updates,
so we could save ourselves some trouble by adding this when there's less
"congestion" in case of any problems.
I agree with Marius.

There’s also a change to the wrap-program procedure that does without
the shell wrappers and instead prepends a short Guile program, which is
read as a comment in the target language. It’s better to play with this
in the next core-updates cycle.

--
Ricardo

GPG: BCA6 89B6 3655 3801 C3C6 2150 197A 5888 235F ACAC
https://elephly.net

Marius Bakke
2017-12-31 14:44:14 UTC
Reply
Permalink
Raw Message
Post by Ludovic Courtès
Hello Guix!
‘core-updates’ is doing OK!
https://hydra.gnu.org/jobset/gnu/core-updates
The remaining issues are GCC 4.8 and 4.9 failing to build, which are
nothing serious and left as an exercise to the reader.
What about starting a new evaluation of all the packages now so we can
merge it early 2018?
Efraim, can you confirm that everything’s alright on aarch64?
We’re lacking a couple of glibc commits from the ‘release/2.26/master’
branch (see below), but Florian Weimer marked them as non-critical
provided we have the previous fixes. Should we include them anyway and
rebuild the whole thing? (I’m inclined to answer “no”.)
I agree, let's not hold up this branch any longer. Godspeed!
Loading...